Add default order by id to one_to_many and many_to_many associations#4996
Draft
philippthun wants to merge 1 commit intocloudfoundry:mainfrom
Draft
Add default order by id to one_to_many and many_to_many associations#4996philippthun wants to merge 1 commit intocloudfoundry:mainfrom
philippthun wants to merge 1 commit intocloudfoundry:mainfrom
Conversation
Member
|
Not sure if this will affect anything other than the public APIs, but I know some users previously run into some issues with service binding ordering changes in app environments: #4665 |
philippthun
force-pushed
the
default-order-by-id-associations
branch
6 times, most recently
from
9ac94f6 to
69a4432
Compare
Adds a Sequel extension that automatically appends ORDER BY id to model queries, ensuring deterministic results for consistent API responses and reliable test behavior in parallel runs. Skips adding the default order when: - Query already has an explicit ORDER BY clause - Query has GROUP BY (aggregated results don't have individual ids) - Query is schema introspection (LIMIT 0) - Query has UNION/INTERSECT/EXCEPT (ORDER BY before UNION is a syntax error) - Query has DISTINCT ON (requires matching ORDER BY) - Query is a subquery (outer query handles ordering) - Model doesn't have id as primary key - id is not in the select list For JOIN queries (including many_to_many associations), it uses a qualified column (table.id) to avoid ambiguity.
philippthun
force-pushed
the
default-order-by-id-associations
branch
from
69a4432 to
e5b44d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures deterministic ordering for all association queries by adding a default
order: :idto the vcap_relations plugin. This fixes sporadic test failures in parallel test runs where database query order was non-deterministic.Explicit order options still override this default, and callers can use
.order(:field)on the dataset to override as needed.Associations with a block (custom dataset transformation) do not get the default order, as the transformation may not be compatible with ordering by id.
Also removes now-redundant explicit
order: :idfrom two models and fixes orgs_visibility to order by service_plan_id (the only column in its select list).I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests