Pass UAA JWT public key to integration sandbox components#2791
Pass UAA JWT public key to integration sandbox components#2791aramprice wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (6)
WalkthroughThe sandbox now loads the UAA JWT public key from the asymmetric UAA configuration asset through memoized helpers. Director, Config Server, and Health Monitor templates render the key dynamically as indented YAML multiline values, and Config Server authentication receives it as Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1d03fea to
09c7499
Compare
09c7499 to
b46f800
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/spec/integration_support/sandbox.rb`:
- Around line 703-709: Extract the duplicated uaa_jwt_public_key logic from
sandbox.rb and director_config.rb into a shared helper or existing shared
utility, then have both callers reuse it. Ensure the shared implementation
explicitly loads YAML with require 'yaml' rather than relying on incidental load
order.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0292c164-c7ad-4f49-b6cd-e3d48dfd1220
📒 Files selected for processing (6)
src/spec/assets/sandbox/director_test.yml.erbsrc/spec/assets/sandbox/health_monitor.yml.erbsrc/spec/assets/sandbox/health_monitor_with_json_logging.yml.erbsrc/spec/integration_support/config_server_helper.rbsrc/spec/integration_support/director_config.rbsrc/spec/integration_support/sandbox.rb
Add a uaa_jwt_public_key helper to Sandbox that reads the RSA public key from the asymmetric uaa.yml test fixture. Wire it into the sandbox config templates so the Director (config_server.uaa and user_management.uaa) and Health Monitor receive the key and can verify token signatures, eliminating the "Decoding token without verifying" warning during integration tests.
b46f800 to
5137347
Compare
Add a uaa_jwt_public_key helper to Sandbox that reads the RSA public key from the asymmetric uaa.yml test fixture. Wire it into the sandbox config templates so the Director (config_server.uaa and user_management.uaa) and Health Monitor receive the key and can verify token signatures, eliminating the "Decoding token without verifying" warning during integration tests.