Cleanup scripts; allow darwin testing by aramprice · Pull Request #148 · cloudfoundry/bosh-utils

aramprice · 2026-08-14T22:57:35Z

Post merge: reconfigure pipeline

coderabbitai · 2026-08-14T22:57:54Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: dd665ec2-3832-4ea7-a16f-1bbd21bbebfd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

The pull request hardens repository build, test, and lint scripts with stable root resolution and strict Bash settings. CI adds lint execution and expands non-Windows workflow coverage to macOS. Unix and Windows process-priority fixtures support command-runner tests. Filesystem tests cover home directories and descriptor closure. Async logger tests use explicit package qualification.

Suggested reviewers: colins, neddp

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 41.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the script cleanup and expanded Darwin testing changes.
Description check	✅ Passed	The description refers to the pipeline changes included in the pull request.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch cleanup-and-modernize

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

re-review

code updated

outdated

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

- remove `test` which used outdated `go fmt` command

- adds `bin/lint`

- remove dot-import - rename package-shadowning vars

This change, and the additiona of a darwin-specific `getProcessPriority()` allows tests to be run on macOS.

This change allows linters for supported GOOS values to pass and reduces the number of programmatically skipped tests.

colins · 2026-08-19T01:34:24Z

+  cd "${ROOT_DIR}"
+  if ! command -v golangci-lint &> /dev/null; then
+    echo "Installing golangci-lint@latest..."
+    go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest


Is this worth pinning to a version to avoid changes to linting causing unexpected failures

colins · 2026-08-19T01:37:29Z

 	return []byte(strings.Join(paths, "|"))
 }, func(data []byte) {
 	paths := strings.Split(string(data), "|")
-	Expect(paths).To(HaveLen(3))


I assume this check was here to avoid index array errors in the following lines
HaveLen(4)?

aramprice changed the base branch from master to develop August 14, 2026 22:58

This comment was marked as resolved.

Sign in to view

cf-foundation-community-automation Bot moved this to Inbox in Foundational Infrastructure Working Group Aug 14, 2026

cf-foundation-community-automation Bot added this to Foundational Infrastructure Working Group Aug 14, 2026

github-project-automation Bot moved this from Inbox to Waiting for Changes | Open for Contribution in Foundational Infrastructure Working Group Aug 14, 2026

aramprice force-pushed the cleanup-and-modernize branch 2 times, most recently from f4ce7d0 to caa7888 Compare August 14, 2026 23:19

aramprice changed the title ~~Cleanup and modernize~~ Cleanup scripts; allow darwin testing Aug 17, 2026

aramprice force-pushed the cleanup-and-modernize branch 4 times, most recently from 32d9593 to 74d8490 Compare August 17, 2026 19:34

aramprice requested a balanced review from Copilot August 17, 2026 19:36

Copilot started reviewing on behalf of aramprice August 17, 2026 19:37 View session

This comment was marked as resolved.

Sign in to view

aramprice force-pushed the cleanup-and-modernize branch 5 times, most recently from c7ef569 to 014e3d3 Compare August 17, 2026 20:27

aramprice requested a balanced review from Copilot August 17, 2026 20:29

Copilot started reviewing on behalf of aramprice August 17, 2026 20:30 View session

This comment was marked as resolved.

Sign in to view

aramprice force-pushed the cleanup-and-modernize branch 2 times, most recently from 8c1e56f to 9535340 Compare August 17, 2026 23:43

aramprice requested a balanced review from Copilot August 18, 2026 00:18

aramprice requested a review from neddp August 18, 2026 21:20

Copilot started reviewing on behalf of aramprice August 18, 2026 21:20 View session

This comment was marked as resolved.

Sign in to view

aramprice force-pushed the cleanup-and-modernize branch 2 times, most recently from bd970ea to a4a1148 Compare August 18, 2026 21:40

aramprice requested a balanced review from Copilot August 18, 2026 21:47

Copilot started reviewing on behalf of aramprice August 18, 2026 21:47 View session

This comment was marked as resolved.

Sign in to view

aramprice force-pushed the cleanup-and-modernize branch from a4a1148 to 6dda9cb Compare August 18, 2026 22:43

aramprice requested a balanced review from Copilot August 18, 2026 22:43

Copilot started reviewing on behalf of aramprice August 18, 2026 22:44 View session

This comment was marked as resolved.

Sign in to view

aramprice force-pushed the cleanup-and-modernize branch from 6dda9cb to a211600 Compare August 18, 2026 22:56

aramprice requested a balanced review from Copilot August 18, 2026 22:56

Copilot AI reviewed Aug 18, 2026

bin: simplifiy / harmonize scripts

bfda38a

- remove `test` which used outdated `go fmt` command

aramprice force-pushed the cleanup-and-modernize branch from a211600 to 0adb725 Compare August 18, 2026 22:59

colins reviewed Aug 19, 2026

View reviewed changes

Comment thread bin/lint Outdated

aramprice added 5 commits August 18, 2026 17:29

ci: introduce lint task

ad426fd

- adds `bin/lint`

Use tool directive instead of tools module pattern

ae5a1dc

Cleanup async logger spec

b6cf51b

- remove dot-import - rename package-shadowning vars

Replace call to nice with bespoke binary

fa6ef98

This change, and the additiona of a darwin-specific `getProcessPriority()` allows tests to be run on macOS.

Split tests into os-specific files

0252e64

This change allows linters for supported GOOS values to pass and reduces the number of programmatically skipped tests.

aramprice force-pushed the cleanup-and-modernize branch from 0adb725 to 0252e64 Compare August 19, 2026 00:29

colins reviewed Aug 19, 2026

View reviewed changes

Uh oh!

Conversation

aramprice commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Reviews paused

Walkthrough

❌ Failed checks (1 warning)

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

colins Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

colins Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aramprice commented Aug 14, 2026 •

edited

Loading

coderabbitai Bot commented Aug 14, 2026 •

edited

Loading

colins Aug 19, 2026 •

edited

Loading