Migrate docker image builds from docker-image to registry-image resource#679
Conversation
Replace deprecated docker-image resource type with registry-image and concourse/oci-build-task for building and pushing Docker images. The docker-image resource forces DOCKER_BUILDKIT=0 (legacy builder) which is incompatible with Docker 28+. - Switch docker-bbl-deployment and cf-deployment-concourse-tasks-bbl-dev resources to registry-image type - Add oci-build-task build steps before each registry-image put - Remove deprecated email field from resource source config
WalkthroughThis PR refactors the Concourse CI pipeline for bosh-bootloader to use explicit task-based Docker image builds. The 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci/pipelines/bosh-bootloader.yml`:
- Line 237: The image_resource entries currently specify only repository:
concourse/oci-build-task which makes CI non-deterministic; update both
image_resource blocks that reference concourse/oci-build-task (the two places
currently just using repository: concourse/oci-build-task) to pin to an
immutable image by adding either a specific digest under version.digest
(preferred) or at minimum a fixed tag such as v0.14.13 so the pipeline uses a
reproducible image; apply the same change to both occurrences.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 89994845-c1de-4f09-8601-ab7afa3a8625
📒 Files selected for processing (1)
ci/pipelines/bosh-bootloader.yml
Summary
docker-imageresource type withregistry-image+concourse/oci-build-taskfor building and pushing Docker images in the BBL pipelineoci-build-taskbuild steps before eachregistry-imageput inbump-bbl-deployment-imageandbbl-downstream-docker-image-bump-deploymentsjobsemailfield fromcf-deployment-concourse-tasks-bbl-devresource source configRoot Cause
The
docker-imageresource forcesDOCKER_BUILDKIT=0(legacy builder), which Docker 28+ has dropped. The image builds successfully but is invisible todocker pushbecause the legacy builder's image store is incompatible with Docker 28's containerd-backed image store. This caused the pipeline's push step to silently fail with justfailed.Approach
Follows the same pattern used in bosh-shared-ci#6:
concourse/oci-build-task(BuildKit-based) to build the image, producingimage/image.tarregistry-imageresourceputwithimage: image/image.tarto push