feat(apps): Add Generate App Manifest functionality#244
Merged
antechrestos merged 4 commits intocloudfoundry-community:mainfrom Jul 5, 2025
Merged
feat(apps): Add Generate App Manifest functionality#244antechrestos merged 4 commits intocloudfoundry-community:mainfrom
antechrestos merged 4 commits intocloudfoundry-community:mainfrom
Conversation
fix(networking): Update _append_encoded_parameter function to append the parameters with the %s=%s format, in order to be compliant with the Policy Server API interface
Member
|
@daviddmd thank you for this contribution. Would you mind adding a test for the Thank you |
Contributor
Author
|
@antechrestos I've added the test for the I've imported the PyYAML ( |
Member
|
@daviddmd thank you very much, I will do a fresh release tomorrow. Good evening |
Member
|
released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cloud Foundry V3 API reference specifies a
manifestendpoint forappsthat returns the computed app manifest YAML (string), matching the cloudfoundry-application-manifest.json schema.I've added the
get_manifestmethod to theAppManagerclass of thecloudfoundry_client/v3/apps.pymodule that consumes this API endpoint.Example:
I've also introduced a fix to the
_append_encoded_parameterfunction of the_get_url_filteredmethod of theentitiesmodule of thenetworkingpackage, in order to append the GET parameters with the%s=%sformat, in line with what the Policy Server API interface expects for its GET requests.Example:
As of now, the following doesn't work as intended:
Expected:
https://<cf-instance>/networking/v1/external/policies?id=97bcba72-43f2-4197-8136-fe178c22846fActual:
https://<cf-instance>/networking/v1/external/policies?q=id%3A97bcba72-43f2-4197-8136-fe178c22846f, which yields all network policies present in the CF instance.