-
Notifications
You must be signed in to change notification settings - Fork 40
Merge develop to master #5909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge develop to master #5909
Conversation
* fix: hide 'reissue' button when not in admin mode Signed-off-by: yuda <yuda@megazone.com> * feat: add currency field to cost report settings section Signed-off-by: yuda <yuda@megazone.com> * feat: include `currency` in adjustment creation request Signed-off-by: yuda <yuda@megazone.com> * chore: update language Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
* feat: disable 'Set Adjustment' button when auto-apply is turned off Signed-off-by: yuda <yuda@megazone.com> * fix: incorrect policy id in adjustment creation request Signed-off-by: yuda <yuda@megazone.com> * chore: add comment Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
* chore: clear createdPolicyIdMap Signed-off-by: yuda <yuda@megazone.com> * chore: clear createdPolicyIdMap in watch Signed-off-by: yuda <yuda@megazone.com> --------- Signed-off-by: yuda <yuda@megazone.com>
Merge cost-report-qa to develop
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
✅ There are no commits in this PR that require review. |
|
🎉 @seungyeoneeee has been randomly selected as the reviewer! Please review. 🙏 |
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR merges the latest develop changes into master, aligning new translation keys and UI enhancements for cost reporting currency features.
- Introduces
COST_REPORT_CURRENCYandCOST_ANALYSIS_CURRENCYkeys across all language packs and console translation definitions. - Updates cost-explorer Vue components to support currency selection in the cost report configuration, adjustments overlay, and currency converter.
- Adds an admin-mode check to conditionally display the reissue button in the upcoming report card component.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/language-pack/ko.json | Updated ISSUE_DATE label and added COST_REPORT_CURRENCY & COST_ANALYSIS_CURRENCY keys. |
| packages/language-pack/ja.json | Added COST_REPORT_CURRENCY & COST_ANALYSIS_CURRENCY translation entries. |
| packages/language-pack/en.json | Added COST_REPORT_CURRENCY & COST_ANALYSIS_CURRENCY translation entries. |
| packages/language-pack/console-translation-2.8.babel | Added new <concept_node> entries for the two new translation keys. |
| apps/web/src/services/cost-explorer/components/CostReportUpcomingReportCard.vue | Introduced isAdminMode store check to gate the reissue button. |
| apps/web/src/services/cost-explorer/components/AdvancedSettingsSetAdjustmentsOverlay.vue | Tracked newly created policy IDs and included currency in adjustment creation API calls. |
| apps/web/src/services/cost-explorer/components/AdvancedSettingsCurrencyConverter.vue | Updated the currency dropdown label to use the new translation key. |
| apps/web/src/services/cost-explorer/components/AdvancedSettingsCostReportConfiguration.vue | Added selectedCurrency state, dropdown, and saving logic for currency in cost report config. |
Comments suppressed due to low confidence (3)
apps/web/src/services/cost-explorer/components/CostReportUpcomingReportCard.vue:50
- The new admin mode gating for showReissueButton lacks unit or integration tests to verify visibility behavior based on isAdminMode.
if (!isAdminMode.value) return false;
apps/web/src/services/cost-explorer/components/AdvancedSettingsSetAdjustmentsOverlay.vue:184
- The addition of currency in createAdjustment should be covered by tests to ensure the correct currency is passed in the API calls.
currency: costReportConfig.value?.currency,
apps/web/src/services/cost-explorer/components/AdvancedSettingsCostReportConfiguration.vue:137
- The payload includes a currency property but the CostReportConfigUpdateParameters type may not include this field, which could lead to type mismatches. Consider updating the type definition to include currency.
currency: state.selectedCurrency,
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
Things to Talk About (optional)