Skip to content

Conversation

@yuda110
Copy link
Member

@yuda110 yuda110 commented May 30, 2025

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

Things to Talk About (optional)

admin-cloudforet and others added 30 commits May 21, 2025 04:40
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
feat: add column at service account attached general accounts table
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
* fix: status bar visibility bug fix

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* fix: bug fix for missing domain

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

---------

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
* feat: add vue query and mutation of `CostReport`

Signed-off-by: yuda <yuda@megazone.com>

* refactor: use VueQuery rather than SpaceConnector

Signed-off-by: yuda <yuda@megazone.com>

* fix: use `select` in `useCostReportConfigQuery`

Signed-off-by: yuda <yuda@megazone.com>

---------

Signed-off-by: yuda <yuda@megazone.com>
* chore: markup "cost report configuration" section

Signed-off-by: yuda <yuda@megazone.com>

* feat: update costReportConfig model

Signed-off-by: yuda <yuda@megazone.com>

* feat: add cost report config form handling and submission logic

Signed-off-by: yuda <yuda@megazone.com>

* chore: update language

Signed-off-by: yuda <yuda@megazone.com>

* chore: edit `CostReportConfigUpdateParameters`

Signed-off-by: yuda <yuda@megazone.com>

* fix: add `DOMAIN` scope to `costReportConfigApiHelper`

Signed-off-by: yuda <yuda@megazone.com>

* chore: delete console.log()

Signed-off-by: yuda <yuda@megazone.com>

---------

Signed-off-by: yuda <yuda@megazone.com>
* chore: edit type of props

Signed-off-by: yuda <yuda@megazone.com>

* feat: add 'Cost Report Adjustments' overlay

Signed-off-by: yuda <yuda@megazone.com>

* chore: update language

Signed-off-by: yuda <yuda@megazone.com>

* chore: update props type

Signed-off-by: yuda <yuda@megazone.com>

---------

Signed-off-by: yuda <yuda@megazone.com>
* feat: update model of report adjustment

Signed-off-by: yuda <yuda@megazone.com>

* feat: add api hook of report adjustment

Signed-off-by: yuda <yuda@megazone.com>

---------

Signed-off-by: yuda <yuda@megazone.com>
Signed-off-by: yuda <yuda@megazone.com>
* refactor: move mutation logic from hook to page

Signed-off-by: yuda <yuda@megazone.com>

* chore: remove manage button from cost report page

Signed-off-by: yuda <yuda@megazone.com>

* feat: delete CostReportSettingsModal (deprecated)

Signed-off-by: yuda <yuda@megazone.com>

---------

Signed-off-by: yuda <yuda@megazone.com>
* feat: update adjustment model

Signed-off-by: yuda <yuda@megazone.com>

* feat: update adjustment model

Signed-off-by: yuda <yuda@megazone.com>

---------

Signed-off-by: yuda <yuda@megazone.com>
…ge-store (#5850)

* feat: add advanced-settings-page-store

Signed-off-by: yuda <yuda@megazone.com>

* refactor: separate component

Signed-off-by: yuda <yuda@megazone.com>

* feat: init adjustment data on overlay open

Signed-off-by: yuda <yuda@megazone.com>

---------

Signed-off-by: yuda <yuda@megazone.com>
* refactor: use vuequery rather than api list

Signed-off-by: yuda <yuda@megazone.com>

* feat: init workspace select dropdown

Signed-off-by: yuda <yuda@megazone.com>

---------

Signed-off-by: yuda <yuda@megazone.com>
* feat: implement `confirmation date` for report

Signed-off-by: yuda <yuda@megazone.com>

* chore: update language

Signed-off-by: yuda <yuda@megazone.com>

* chore: replace with helper

Signed-off-by: yuda <yuda@megazone.com>

---------

Signed-off-by: yuda <yuda@megazone.com>
* feat: add 'reissue' button

Signed-off-by: yuda <yuda@megazone.com>

* chore: update language

Signed-off-by: yuda <yuda@megazone.com>

* chore: delete invalidating query cache

Signed-off-by: yuda <yuda@megazone.com>

* fix: set proper return value

Signed-off-by: yuda <yuda@megazone.com>

---------

Signed-off-by: yuda <yuda@megazone.com>
* feat: add `input-left` slot to PTextInput

Signed-off-by: yuda <yuda@megazone.com>

* feat: set provider, adjustment select dropdown

Signed-off-by: yuda <yuda@megazone.com>

* chore: update language

Signed-off-by: yuda <yuda@megazone.com>

---------

Signed-off-by: yuda <yuda@megazone.com>
* feat: add `isAllWorkspaceSelected` to policy data

Signed-off-by: yuda <yuda@megazone.com>

* chore: update model

Signed-off-by: yuda <yuda@megazone.com>

* chore: show reissue button only on specific date

Signed-off-by: yuda <yuda@megazone.com>

* chore: edit adjustment valid condition

Signed-off-by: yuda <yuda@megazone.com>

---------

Signed-off-by: yuda <yuda@megazone.com>
* chore: edit model schema

Signed-off-by: yuda <yuda@megazone.com>

* feat: apply CRUD for Adjustment Policy

Signed-off-by: yuda <yuda@megazone.com>

* fix: fix query key

Signed-off-by: yuda <yuda@megazone.com>

* chore: add translate

Signed-off-by: yuda <yuda@megazone.com>

---------

Signed-off-by: yuda <yuda@megazone.com>
* chore: change unit from PERCENTAGE to PERCENT

Signed-off-by: yuda <yuda@megazone.com>

* chore: fix adjustment validation

Signed-off-by: yuda <yuda@megazone.com>

* chore: sort adjustments

Signed-off-by: yuda <yuda@megazone.com>

* feat: create/update/delete/change-order adjustment items

Signed-off-by: yuda <yuda@megazone.com>

---------

Signed-off-by: yuda <yuda@megazone.com>
* fix: fix promise bug when save adjustments

Signed-off-by: yuda <yuda@megazone.com>

* chore: sort with order

Signed-off-by: yuda <yuda@megazone.com>

* chore: do not raise api when there's no change

Signed-off-by: yuda <yuda@megazone.com>

---------

Signed-off-by: yuda <yuda@megazone.com>
* chore: update model type

Signed-off-by: yuda <yuda@megazone.com>

* chore: set updated spec

Signed-off-by: yuda <yuda@megazone.com>

* feat: update cost report detail page

Signed-off-by: yuda <yuda@megazone.com>

* chore: update language

Signed-off-by: yuda <yuda@megazone.com>

* chore: edit minor style

Signed-off-by: yuda <yuda@megazone.com>

* chore: delete console.log

Signed-off-by: yuda <yuda@megazone.com>

* chore: update minor style

Signed-off-by: yuda <yuda@megazone.com>

---------

Signed-off-by: yuda <yuda@megazone.com>
Signed-off-by: yuda <yuda@megazone.com>
yuda110 and others added 10 commits May 29, 2025 10:47
Signed-off-by: yuda <yuda@megazone.com>
* feat: update provider section

Signed-off-by: yuda <yuda@megazone.com>

* chore: set sorting

Signed-off-by: yuda <yuda@megazone.com>

---------

Signed-off-by: yuda <yuda@megazone.com>
Signed-off-by: yuda <yuda@megazone.com>
* feat: add sync-currency API scheme

Signed-off-by: yuda <yuda@megazone.com>

* feat: add 'Sync exchange rate' button

Signed-off-by: yuda <yuda@megazone.com>

* chore: update language

Signed-off-by: yuda <yuda@megazone.com>

---------

Signed-off-by: yuda <yuda@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
…posable

Signed-off-by: samuel.park <samuel.park@megazone.com>
…pagination query

Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
…ble and `pagination` flag to `useServiceQueryKey`

feat(use-pagination-query): create `useScopedPaginationQuery` composable and `pagination` flag to `useServiceQueryKey`
@vercel
Copy link

vercel bot commented May 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 7:44am
cost-report ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 7:44am
web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 7:44am

@github-actions
Copy link
Contributor

⚠️ @yuda110 the signed-off-by was not found in the following 4 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@github-actions
Copy link
Contributor

🎉 @seungyeoneeee has been randomly selected as the reviewer! Please review. 🙏

@github-actions
Copy link
Contributor

✅ There are no commits in this PR that require review.

@yuda110 yuda110 merged commit 110276e into master Jun 2, 2025
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants