chore(alert-service-pagination): fix minor bug about pagination bug after filtering name #5880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 이승연 <sylee1274@mz.co.kr>
seungyeoneeee
added
the
self_approved/review
Contributor
|
✅ There are no commits in this PR that require review. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a pagination issue by always resetting the healthy and unhealthy page numbers whenever filters change, rather than only when a full name filter is applied.
- Removed the
isFullNameOnlycheck. - Moved page reset calls outside of the conditional guard.
- Ensures pagination is reset on any filter update.
Comments suppressed due to low confidence (2)
apps/web/src/services/alert-manager/v2/components/ServiceList.vue:88
- Add a unit test to verify that both healthy and unhealthy page numbers are reset to 1 on any filter change, ensuring the new behavior is covered.
serviceListPageStore.setUnhealthyPage(1);
apps/web/src/services/alert-manager/v2/components/ServiceList.vue:88
- [nitpick] Consider extracting the consecutive page reset calls into a single helper method (e.g.,
serviceListPageStore.resetPages()) to reduce duplication and clarify intent.
serviceListPageStore.setUnhealthyPage(1);
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
Things to Talk About (optional)