fix: handle 404 error gracefully by setting default values #5727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
…`) (#5717) * chore(api-doc): edit api-doc file name Signed-off-by: samuel.park <samuel.park@megazone.com> * feat(query-client): separate query client (reference/service) Signed-off-by: samuel.park <samuel.park@megazone.com> * feat(query-key): create app context query key composable Signed-off-by: samuel.park <samuel.park@megazone.com> * feat(query-key): create new api query key composable Signed-off-by: samuel.park <samuel.park@megazone.com> * fix(service-context-query): apply new query key Signed-off-by: samuel.park <samuel.park@megazone.com> * chore(query-key): edit dir architecture & add doc/test/debugger Signed-off-by: piggggggggy <samuel.park@mz.co.kr> * Revert "fix(service-context-query): apply new query key" This reverts commit 27134bf. Signed-off-by: piggggggggy <samuel.park@mz.co.kr> * fix(query-key): refactor api query-key composable Signed-off-by: piggggggggy <samuel.park@mz.co.kr> * chore(query-key): edit snapshot test result Signed-off-by: piggggggggy <samuel.park@mz.co.kr> * feat(api-query-key): add `namespaces` return value to composable Signed-off-by: piggggggggy <samuel.park@mz.co.kr> * feat(service-query-key): apply service query-key review (improvement & optimization) Signed-off-by: samuel.park <samuel.park@megazone.com> * chore(global-query-client): add annotation Signed-off-by: samuel.park <samuel.park@megazone.com> * chore: solve conflict Signed-off-by: samuel.park <samuel.park@megazone.com> * chore: small fix Signed-off-by: samuel.park <samuel.park@megazone.com> * fix(service-query-key): apply opened type to params Signed-off-by: samuel.park <samuel.park@megazone.com> * chore(docs&test): apply changed return type Signed-off-by: samuel.park <samuel.park@megazone.com> * chore: remove unnecessary reactive Signed-off-by: samuel.park <samuel.park@megazone.com> --------- Signed-off-by: samuel.park <samuel.park@megazone.com> Signed-off-by: piggggggggy <samuel.park@mz.co.kr>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
skdud4659
added
the
self_approved/review
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
✅ There are no commits in this PR that require review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
SSIA
Things to Talk About (optional)