Skip to content

Conversation

@piggggggggy
Copy link
Member

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

  • Create New service query key composable (_useAPIQueryKey)
    • New query key management method has been applied.
    • Existing composable(useAPIQueryKey) will be replaced soon.
    • Each api resource has a base resource key file. (keys.ts in schema dir)

image

Things to Talk About (optional)

Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
…yKey)

Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
@vercel
Copy link

vercel bot commented Mar 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2025 6:34am
dashboard ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2025 6:34am
feature-service-account-budget ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2025 6:34am
global-config ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2025 6:34am
service-account-budget ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2025 6:34am
web-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2025 6:34am

@github-actions
Copy link
Contributor

🎉 @seungyeoneeee and @WANZARGEN have been randomly selected as the reviewers! Please review. 🙏

Copy link
Member

@WANZARGEN WANZARGEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two comments:

  1. Check the dependencies between keys. (query, api client directories)
  2. separate two query clients (service, reference)

Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
@github-actions
Copy link
Contributor

⚠️ @piggggggggy the signed-off-by was not found in the following 2 commits:

  • a9cda64: draft: reference query
  • 2685921: draft: create reference query

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants