Skip to content

Conversation

@piggggggggy
Copy link
Member

@piggggggggy piggggggggy commented Mar 6, 2025

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

  • Separated route-constant (admin / workspace)
  • Removed usage of makeAdminRouteName helper

Things to Talk About (optional)

Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
@vercel
Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2025 5:38am
dashboard ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2025 5:38am
inventory-v2 ⬜️ Ignored (Inspect) Mar 6, 2025 5:38am
web-storybook ⬜️ Ignored (Inspect) Mar 6, 2025 5:38am

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

🎉 @seungyeoneeee and @WANZARGEN have been randomly selected as the reviewers! Please review. 🙏

@piggggggggy piggggggggy added the self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers. label Mar 6, 2025
@piggggggggy piggggggggy merged commit 772e746 into develop Mar 6, 2025
11 of 12 checks passed
@github-actions github-actions bot mentioned this pull request Mar 27, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pass/signedoff self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants