Skip to content

Conversation

@kkdy21
Copy link
Contributor

@kkdy21 kkdy21 commented Feb 5, 2025

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

Things to Talk About (optional)

piggggggggy and others added 19 commits January 23, 2025 15:38
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.5.3 to 4.5.6.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v4.5.6/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.6/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Wanjin Noh <wanjin@megazone.com>
refactor: restructure styles and update imports

- Moved style files to a new package directory
- Updated import paths for colors, screens, and fonts
- Added mirinae-foundation as a dependency in package.json

Signed-off-by: sulmo <sulmo@megazone.com>

refactor(tailwind): simplify config by extending default settings

- Replaced custom Tailwind configuration with an extended default config
- Removed redundant theme, variants, and plugins definitions
- Updated content paths for style processing

Signed-off-by: sulmo <sulmo@megazone.com>
…ncerns

Signed-off-by: sulmo <sulmo@megazone.com>
Signed-off-by: sulmo <sulmo@megazone.com>
…irinae-foundation

Signed-off-by: sulmo <sulmo@megazone.com>
- Removed `@storybook/theming` dependency and replaced with custom theme creation.
- Updated import paths and methods for setting Storybook configurations.
- Adjusted package.json to reflect changes in dependencies.
- Simplified path resolution in storybook-config-custom.

Signed-off-by: sulmo <sulmo@megazone.com>
- Change the development server port from 6006 to 6007 in the script configuration.

Signed-off-by: sulmo <sulmo@megazone.com>
feat(web-storybook): create storybook setup & refactor for separation of concerns
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: admin-cloudforet <admin@cloudforet.io>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
* feat: add deepClamp mode

* feat: create v2 v3

Signed-off-by: daeyeon ko <rowan@megazone.com>

* feat: main logic

Signed-off-by: daeyeon ko <rowan@megazone.com>

* feat: trunk ,collapse condition and style inherit

Signed-off-by: daeyeon ko <rowan@megazone.com>

* refactor: slot change detection and edge case handling

Signed-off-by: daeyeon ko <rowan@megazone.com>

* refactor: remove double loop

Signed-off-by: daeyeon ko <rowan@megazone.com>

* refactor: combine the implementation of PCollapsiblePanelV2 into PCollapsiblePanel

Signed-off-by: daeyeon ko <rowan@megazone.com>

* refactor:  remove duplicate code

Signed-off-by: daeyeon ko <rowan@megazone.com>

* refactor: seperate the clamping logic with a hook

Signed-off-by: daeyeon ko <rowan@megazone.com>

* chore: write storybook

Signed-off-by: daeyeon ko <rowan@megazone.com>

* refactor: hidden slot when recursive mode

Signed-off-by: daeyeon ko <rowan@megazone.com>

* refactor: active recursive mode of opsflow collapsible panel

Signed-off-by: daeyeon ko <rowan@megazone.com>

* style: change variable, function name

Signed-off-by: daeyeon ko <rowan@megazone.com>

* style: change function name

Signed-off-by: daeyeon ko <rowan@megazone.com>

* feat: add deepClamp mode

Signed-off-by: daeyeon ko <rowan@megazone.com>

* fix: change prop passing variable name

Signed-off-by: daeyeon ko <rowan@megazone.com>

* refactor: enhanced type stability

Signed-off-by: daeyeon ko <rowan@megazone.com>

---------

Signed-off-by: daeyeon ko <rowan@megazone.com>

* refactor: add component props type

Signed-off-by: daeyeon ko <rowan@megazone.com>

---------

Signed-off-by: daeyeon ko <rowan@megazone.com>
- Updated the turbo package from version 1.13.4 to 2.3.4.
- Modified configuration in turbo.json, changing "pipeline" to "tasks".
- Added a persistent flag to the dev task in turbo.json.

Signed-off-by: sulmo <sulmo@megazone.com>
* feat: create unified-storybook app

feat(unified-storybook): add initial setup for unified storybook

- Added ESLint configuration and ignore files
- Configured Storybook with custom themes and settings
- Introduced PostCSS and Tailwind CSS configurations
- Included icons, manifest, and other public assets
- Set up TypeScript configuration for the project
feat(unified-storybook): add initial setup for unified storybook

- Added ESLint configuration and ignore files
- Configured Storybook with custom themes and settings
- Introduced PostCSS and Tailwind CSS configurations
- Included icons, manifest, and other public assets

Signed-off-by: sulmo <sulmo@megazone.com>

* chore: translate introduce docs

docs: update storybook introduction to english

- Translated the Storybook overview and sections from Korean to English.
- Updated component descriptions for clarity and consistency.
```

Signed-off-by: sulmo <sulmo@megazone.com>

* style: update eslint and tsconfig settings for storybook apps

- Disabled ESLint rule for import dependencies in vite config files
- Removed .eslintignore file from unified-storybook
- Simplified .eslintrc.js by removing custom rules and settings
- Cleaned up tsconfig.json by removing unused paths and types

Signed-off-by: sulmo <sulmo@megazone.com>

* chore(unified-storybook): update script name and turbo config

- Renamed the development script for unified-storybook.
- Added configuration for the new script in turbo.json.

Signed-off-by: sulmo <sulmo@megazone.com>

---------

Signed-off-by: sulmo <sulmo@megazone.com>
Signed-off-by: daeyeon ko <rowan@megazone.com>
Signed-off-by: daeyeon ko <rowan@megazone.com>
#5616)

* chore: create a workflow form master to develop

Signed-off-by: daeyeon ko <rowan@megazone.com>

* chore: dispatch merge workflow

Signed-off-by: daeyeon ko <rowan@megazone.com>

* chore: add a workflow to check commits that are targets for revert in pr

Signed-off-by: daeyeon ko <rowan@megazone.com>

---------

Signed-off-by: daeyeon ko <rowan@megazone.com>
@kkdy21 kkdy21 requested a review from sulmoJ February 5, 2025 01:08
@vercel
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Feb 5, 2025 1:08am
dashboard ⬜️ Ignored (Inspect) Feb 5, 2025 1:08am
inventory-v2 ⬜️ Ignored (Inspect) Feb 5, 2025 1:08am

@github-actions github-actions bot added the pending/review Pull Request is awaiting review. No reviewers have started reviewing yet. label Feb 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

⚠️ @kkdy21 the signed-off-by was not found in the following 2 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

✅ There are no commits in this PR that require review.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

🎉 @WANZARGEN and @seungyeoneeee have been randomly selected as the reviewers! Please review. 🙏

Copy link
Member

@sulmoJ sulmoJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㄱㄱㄱ

@github-actions github-actions bot removed the pending/review Pull Request is awaiting review. No reviewers have started reviewing yet. label Feb 5, 2025
@github-actions github-actions bot added the approved/review Pull Request has been approved. All reviewers have signed off and no further changes are required. label Feb 5, 2025
@kkdy21 kkdy21 merged commit f4449f7 into master Feb 5, 2025
13 of 16 checks passed
@github-actions github-actions bot removed the approved/review Pull Request has been approved. All reviewers have signed off and no further changes are required. label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants