Skip to content

Conversation

@piggggggggy
Copy link
Member

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

Things to Talk About (optional)

…-folder

Signed-off-by: samuel.park <samuel.park@megazone.com>
@piggggggggy piggggggggy added the self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers. label Jan 23, 2025
@vercel
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 4:36am
dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 4:36am
inventory-v2 ⬜️ Ignored (Inspect) Jan 23, 2025 4:36am

@github-actions
Copy link
Contributor

⚠️ @piggggggggy the signed-off-by was not found in the following 1 commits:

  • 1c6d00e: Revert "chore(dashboard): apply new sorting policy to dashboard and dashboard-folder"

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

…ashboard-folder"

This reverts commit d481e1b.
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
@piggggggggy piggggggggy force-pushed the hotfix-dashbaord-sorting branch from 9e9d9f7 to 4e9e7a7 Compare January 23, 2025 04:36
@piggggggggy piggggggggy merged commit 9492049 into master Jan 23, 2025
9 checks passed
@piggggggggy piggggggggy deleted the hotfix-dashbaord-sorting branch January 23, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fail/signedoff pass/signedoff self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants