Skip to content

Conversation

@piggggggggy
Copy link
Member

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

Things to Talk About (optional)

Signed-off-by: samuel.park <samuel.park@megazone.com>
fix(cost-analysis): add project-group filter
…orer/cost-analysis/dashboard (#5577)

* feat: create group by filter constant

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat(dashboard): add project group variable preset

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat(cost-query-set): apply changed filter schema to managed query set

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat(cost-filter-item): apply group-by filter constant to filter item hook

Signed-off-by: samuel.park <samuel.park@megazone.com>

* feat: apply project group filtering to metric group by

Signed-off-by: samuel.park <samuel.park@megazone.com>

* chore: small fix

Signed-off-by: samuel.park <samuel.park@megazone.com>

---------

Signed-off-by: samuel.park <samuel.park@megazone.com>
@piggggggggy piggggggggy added the self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers. label Jan 21, 2025
@vercel
Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Jan 21, 2025 0:38am
dashboard ⬜️ Ignored (Inspect) Jan 21, 2025 0:38am
inventory-v2 ⬜️ Ignored (Inspect) Jan 21, 2025 0:38am

@github-actions
Copy link
Contributor

🎉 @sulmoJ and @Hansoo-mzc have been randomly selected as the reviewers! Please review. 🙏

@github-actions github-actions bot requested review from Hansoo-mzc and sulmoJ January 21, 2025 12:38
@github-actions
Copy link
Contributor

⚠️ @piggggggggy the signed-off-by was not found in the following 1 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@piggggggggy piggggggggy deleted the feature-project-group-filter branch January 22, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fail/signedoff self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants