Skip to content

Conversation

@seungyeoneeee
Copy link
Contributor

To Reviewers

  • Self-reviewed (coding conventions, bug-free, functionality verified, tests checked, documentation updated)
  • Minor change, review optional (style, chore, ci, straightforward changes, etc.)
  • Previously reviewed in feature branch, no further review needed
  • Need review or discussion

Description (optional)

Things to Talk About (optional)

skdud4659 and others added 8 commits January 9, 2025 16:21
* chore: apply loading min-height

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply message tab at webhook

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

---------

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
* fix: fixed event rule update bug

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: add validation check at service key

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* fix: fixed event rule bugs

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply qa issue

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* chore: update translations

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply read write access check

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* chore: remove console.log

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

---------

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
* fix: fixed event rule mount bug

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* refactor: changed file, type name

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply alert history modal

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* chore: update translations

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

---------

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
…te form (#5472)

* feat: create notification protocol select dropdown

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* chore: update translations

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: add forward protocol icon

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* refactor: changed forward channel icon and apply protocol list

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* fix: fixed service edit bug

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

---------

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
… qa issue (#5473)

* fix: update bug about not showing show-more button

Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>

* feat: update notification API to AlertManagerV2 API with branch processing

Signed-off-by: 이승연 <sylee1274@mz.co.kr>

* fix: update minor bug of not selecting multiple items

Signed-off-by: 이승연 <sylee1274@mz.co.kr>

* fix: fix minor type error and remove console.log

Signed-off-by: 이승연 <sylee1274@mz.co.kr>

---------

Signed-off-by: seungyeoneeee <sylee1274@mz.co.kr>
Signed-off-by: 이승연 <sylee1274@mz.co.kr>
* feat: back navigation route modification

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply table at service delete modal

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

* feat: apply error tab at webhook

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>

---------

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
…5476)

Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
* feat: update addUser logic with roleBinding reference store

Signed-off-by: 이승연 <sylee1274@mz.co.kr>

* fix: update minor change

Signed-off-by: 이승연 <sylee1274@mz.co.kr>

* feat: update user logic related roleBinding

Signed-off-by: 이승연 <sylee1274@mz.co.kr>

* feat: remove unnecessary file

Signed-off-by: 이승연 <sylee1274@mz.co.kr>

---------

Signed-off-by: 이승연 <sylee1274@mz.co.kr>
@vercel
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
inventory-v2 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 8:26am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 8:26am
dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 8:26am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants