Fix logback incompatibility issues and copy com.latch.LengthSplittingAppender into project (#143) #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
There are some tests that are failing that need to be fixed before mergin. On the topic of attribution in regards to the MIT license. You can either copy the copyright and permission notice from the repo to the top of each file you've copied or add another section to our LICENSE file that is clear about which files were copied. Although I like the first approach more as that is the most explicit and won't fail to attribute in case some folders change due to refactorings. |
rspiegl
requested changes
Jun 12, 2025
platform-spring-bom/platform-spring-logging-server-config/build.gradle
Outdated
Show resolved
Hide resolved
...ver-config/src/test/java/io/cloudflight/platform/spring/logging/LoggingJsonSplitterTest.java
Show resolved
Hide resolved
...bom/platform-spring-logging-server-config/src/main/java/com/latch/SplittingAppenderBase.java
Show resolved
Hide resolved
...ng-bom/platform-spring-logging-server-config/src/main/java/com/latch/LoggingEventCloner.java
Show resolved
Hide resolved
...m/platform-spring-logging-server-config/src/main/java/com/latch/LengthSplittingAppender.java
Show resolved
Hide resolved
rspiegl
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143
This MR copies the content of the logback-length-splitting-appender repository into the platform-spring-logging-server-config module and fixes compatibility issues with logback-classic versions 1.5.x.
The repository has an MIT license, which by my understanding I need to include somewhere in the copied code, but I am not quite sure where the best place for it would be.