Fix off-by-one and macro impls for TypedArray - #7107
Open
LordGoatius wants to merge 2 commits into
Open
Conversation
LordGoatius
force-pushed
the
cloudflare/jimmyostler/jsg-rs-fixes
branch
from
August 24, 2026 21:43
3dd6648 to
633583e
Compare
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
|
|
||
| pub fn get(&self, index: usize) -> Local<'a, Value> { | ||
| debug_assert!(index <= self.len(), "index out of bounds"); | ||
| debug_assert!(index < self.len(), "index out of bounds"); |
Contributor
There was a problem hiding this comment.
FunctionCallbackInfo::operator[] returns undefined for missing arguments, and the generated #[jsg_method] callbacks deliberately call args.get() for every declared parameter so omitted arguments can flow through FromJS. This debug-only assertion therefore panics for normal calls such as a zero-argument invocation of a two-parameter Rust method, while release builds accept the call. Preserve V8’s missing-argument behavior.
Suggested change
| debug_assert!(index < self.len(), "index out of bounds"); | |
| // V8 returns undefined for missing callback arguments. |
Contributor
|
I'm Bonk, and I've done a quick review of your PR. PR #7107 corrects TypedArray casting and callback argument bounds.
Validation could not run: Bazel lacks libc++ headers ( Time for a pun! That assertion was out of bounds. |
jasnell
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Access beyond bounds is just undefined, but for both of the changes correctness is best.