08-24-26 Build maintenance - #7104
Open
fhanau wants to merge 1 commit into
Open
Conversation
Contributor
|
LGTM |
fhanau
force-pushed
the
felix/082426-build
branch
2 times, most recently
from
August 24, 2026 20:00
22f241d to
2afd48c
Compare
- Always use Rust cc_common_link - Enable DEFLATE_CHUNK_WRITE_64LE for zlib to make compression slightly faster and match the downstream build - Update non-automated protobuf - Unfreeze dependencies. To fix the Windows build, we need to make one target Linux-only since rules_js 3.1.2 produces an error instead of failing silently when dealing with a malformed symlink path (see aspect-build/rules_js#2826) rules_esbuild and rules_ts can be unfrozen too, they were fine themselves and apparently only got frozen since they pull in a more recent version of rules_js than we were using which made the rules_js freeze ineffective.
fhanau
force-pushed
the
felix/082426-build
branch
from
August 24, 2026 20:45
2afd48c to
34fec5a
Compare
fhanau
marked this pull request as ready for review
August 24, 2026 20:55
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7104 +/- ##
===========================================
- Coverage 67.83% 34.83% -33.00%
===========================================
Files 459 794 +335
Lines 130147 254483 +124336
Branches 21284 21295 +11
===========================================
+ Hits 88285 88649 +364
- Misses 28939 152910 +123971
- Partials 12923 12924 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Hash seems fried on macOS: |
Member
|
There's also some annoying GitHub bug that's making the page jump when I try to review... this is fun. |
npaun
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credit for discovering that we were missing DEFLATE_CHUNK_WRITE_64LE goes to Bill Sobel. This optimization was only introduced after we started using Chromium zlib in workerd.