Skip writable abort task if no current request - #7102
Open
jasnell wants to merge 1 commit into
Open
Conversation
jsrpc WritableStream adapter tries to abort if it is destroyed without an explicit abort. If that happens during IoContext cleanup when there's no active request, getMetrics complains with a KJ_REQUIRE about the lack of a current request. Guard by checking first.
Contributor
|
LGTM! |
jasnell
enabled auto-merge
August 25, 2026 02:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsrpc WritableStream adapter tries to abort if it is destroyed without an explicit abort. If that happens during IoContext cleanup when there's no active request, getMetrics complains with a KJ_REQUIRE about the lack of a current request. Guard by checking first.