Fix node:fs cp to handle symlinks when copying into subdirectories - #7098
Open
ryanking13 wants to merge 1 commit into
Open
Fix node:fs cp to handle symlinks when copying into subdirectories#7098ryanking13 wants to merge 1 commit into
ryanking13 wants to merge 1 commit into
Conversation
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
Contributor
|
I'm Bonk, and I've done a quick review of your PR. PR #7098 snapshots source directory entries before recursive
|
ryanking13
force-pushed
the
gyeongjae/fs-symlink-copy
branch
2 times, most recently
from
August 24, 2026 07:56
b7ba948 to
3f277db
Compare
fhanau
approved these changes
Aug 24, 2026
jasnell
approved these changes
Aug 24, 2026
ryanking13
force-pushed
the
gyeongjae/fs-symlink-copy
branch
from
August 25, 2026 02:57
3f277db to
dd648d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes node:fs cp functions to handle subdirectories that contain symlink properly.
When the
destdirectory contains a symlink to thesrcdirectory, it could free up the memory of thesrcdirectory during the copy.This fixes it by holding a refcount of all the entries in the src directory before performing the copy.