workflows: add experimental subscribe support - #7087
Open
mkuritsu wants to merge 2 commits into
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
mkuritsu
force-pushed
the
rcorreia/experimental-workflows-subscribe
branch
from
August 21, 2026 18:37
e30472a to
d0546dc
Compare
Author
|
I have read the CLA Document and I hereby sign the CLA |
mkuritsu
force-pushed
the
rcorreia/experimental-workflows-subscribe
branch
from
August 24, 2026 13:36
d0546dc to
c9f81d2
Compare
danlapid
reviewed
Aug 24, 2026
| } | ||
|
|
||
| const subscription = await this.#fetcher.subscribe(this.id, options); | ||
| Object.defineProperty(subscription, Symbol.asyncIterator, { |
Collaborator
There was a problem hiding this comment.
I'd rather not ship it this way, we should ship something JSRPC native instead.
Unclear if a JSRPC native impl will have the same interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the experimental
workflows_instance_subscribecompatibility flag to gate the new workflows event subscription feature. It also adds the required api fetcher implementation.This intentionally does not update public types since the feature is behind a experimental compat flag, public types will be deferred to a later PR enabling the feature publicly