JSRPC: Implement serialization of Blob.#6815
Open
G4brym wants to merge 1 commit into
Open
Conversation
03ec182 to
d8d741e
Compare
Registers Blob as a serializable host type (new `blob` SerializationTag), so it can be passed over built-in JSRPC and cloned via structuredClone() / postMessage(), matching the spec which lists Blob as a serializable object. It is serialized as its MIME type followed by its raw bytes. The File subclass is intentionally left non-serializable.
d8d741e to
56beba5
Compare
Merging this PR will degrade performance by 10.37%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | Encode_ASCII_1024[TextEncoder][0/0/1024] |
3.3 ms | 3.7 ms | -10.37% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing G4brym:blob-jsrpc-serialization (56beba5) with main (5be9cba)
Footnotes
-
129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
Blobserializable so it round-trips through JSRPC,structuredClone(), andpostMessage(), per the structured-clone spec. Serialized as MIME type + raw bytes.No new compat flag: this is net-new behavior (
Blobpreviously threw), not a breaking change, so it doesn't seem to warrant one, happy to add one if reviewers think otherwise.