Fix HA connection metric for failed tunnel dials#1638
Open
officialasishkumar wants to merge 1 commit intocloudflare:masterfrom
Open
Fix HA connection metric for failed tunnel dials#1638officialasishkumar wants to merge 1 commit intocloudflare:masterfrom
officialasishkumar wants to merge 1 commit intocloudflare:masterfrom
Conversation
Count active HA connections only after a tunnel connection has successfully registered with the edge. Failed dial or registration attempts now leave cloudflared_tunnel_ha_connections at zero, matching the metric description and avoiding misleading readiness data. Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloudflared_tunnel_ha_connectionsonly after a tunnel connection successfully registers with the edgeFixes #1633.
Testing
git diff --checkgo test -mod=vendor ./supervisorgo test -mod=vendor ./supervisor ./connectiongo test -mod=vendor ./...(local environment failure limited toingressICMP tests because this container cannot create the required ping/raw sockets: GID 1000 is outsideping_group_rangeand ICMPv6 socket creation is denied)