Skip to content

chore: add docs triage skill#31697

Draft
elithrar wants to merge 1 commit into
productionfrom
docs-triage-skill
Draft

chore: add docs triage skill#31697
elithrar wants to merge 1 commit into
productionfrom
docs-triage-skill

Conversation

@elithrar

Copy link
Copy Markdown
Collaborator

Summary

Adds a docs-triage agent skill for replaying Cloudflare docs PR triage workflows. The skill captures queue filters, readiness gates, shallow review checks, and approval/auto-merge safeguards based on recent triage sessions.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
* @cloudflare/product-owners

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

This PR adds a new docs-triage agent skill (.agents/skills/docs-triage/SKILL.md) that codifies workflows for triaging, shallow-reviewing, and auto-merging docs PRs. It is a focused, well-structured change (1 file, ~200 lines) and aligns with the existing skill layout under .agents/skills/.

Suggested Labels

  • chore
  • agents
  • skill

Issues Flagged

1. Incorrect skill references (line 181)
The shallow-review checklist says:

If the PR touches Workers code examples or Cloudflare API usage, load code-review. If reviewing docs content deeply or posting suggestions, load docs-review.

The exact skill names registered in this repo are workers-code-review and contributing (there is no code-review or docs-review skill). Loading a non-existent skill will cause the agent to fail. Please update these references to the canonical names:

  • code-reviewworkers-code-review
  • docs-reviewcontributing (or remove the reference if it's meant to be a future skill)

2. Missing trailing newline at EOF
The file ends without a trailing newline. While minor, many tools and style conventions expect a newline at the end of text files.

What’s Good

  • Clear progressive-discovery workflow and well-defined triage gates.
  • Commands are accurate and executable (verified gh pr list --json fields against gh v2.95).
  • Good coverage of approval safeguards (explicit confirmation before acting, re-checking state, auto-merge with squash).
  • No contractions, filler phrases, or directional language issues.

Recommendation

Approve after addressing the skill-name references. The trailing newline is optional but appreciated.

@ask-bonk

ask-bonk Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Posted a review on PR #31697.

What the PR changes

Adds a single new agent skill at .agents/skills/docs-triage/SKILL.md (~197 lines) that captures reproducible workflows for triaging Cloudflare docs PRs. It covers progressive discovery, readiness gates, size/ownership classification, quick gh CLI commands, and safeguards for approval/auto-merge.

Suggested labels

  • chore
  • agents
  • skill

Issues flagged

  1. Incorrect skill references (line 181) — The text tells the agent to load code-review and docs-review, but the registered skills are workers-code-review and contributing. Loading a non-existent skill will break the agent workflow. I recommended updating to the canonical names.
  2. Missing trailing newline at EOF — Minor, but noted for cleanliness.

Verdict

The PR is small, well-scoped, and consistent with the existing skill structure. I recommended approval after fixing the skill-name references.

github run

@github-actions

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant