[Logs] Update Logpush dataset field definitions (2026-06-16)#31486
[Logs] Update Logpush dataset field definitions (2026-06-16)#31486soheiokamoto wants to merge 1 commit into
Conversation
|
/bonk please review this automated sync of Logpush dataset field definitions. Focus on the following:
|
Review✅ No style-guide issues found in commit CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue needs fixing before merge.
Duplicate changelog entry — The 'New datasets' section lists WebSocket Analytics twice (lines 11–12). This appears to be a code generator bug in the source data or template. The PR description also contains the same duplicate.
Labels — Already appropriately labeled (, , ).
Manual edit risk — No manual edits appear at risk of being overwritten. All new field descriptions in and both files follow the generated format consistently.
Field description quality — Descriptions are accurate and consistent with existing generated dataset pages. The new WebSocket Analytics fields and Email Security Alert fields look correct.
| - **WebSocket Analytics**: A new dataset with fields including `BytesReceivedClient`, `BytesReceivedOrigin`, `BytesSentClient`, `BytesSentOrigin`, `ClientASN`, `ClientIP`, `ClientRequestHost`, `ClientRequestPath`, `ClientRequestUserAgent`, `ColoCode`, `ConnectionCloseReason`, `ConnectionCloseSource`, `ConnectionID`, `ConnectionTransportCloseCode`, `EdgeEndTimestamp`, `EdgeStartTimestamp`, and `RayID`. | ||
| - **WebSocket Analytics**: A new dataset with fields including `BytesReceivedClient`, `BytesReceivedOrigin`, `BytesSentClient`, `BytesSentOrigin`, `ClientASN`, `ClientIP`, `ClientRequestHost`, `ClientRequestPath`, `ClientRequestUserAgent`, `ColoCode`, `ConnectionCloseReason`, `ConnectionCloseSource`, `ConnectionID`, `ConnectionTransportCloseCode`, `EdgeEndTimestamp`, `EdgeStartTimestamp`, and `RayID`. |
There was a problem hiding this comment.
Remove the duplicate WebSocket Analytics bullet. Check the generator source — this dataset may be emitted twice.
| - **WebSocket Analytics**: A new dataset with fields including `BytesReceivedClient`, `BytesReceivedOrigin`, `BytesSentClient`, `BytesSentOrigin`, `ClientASN`, `ClientIP`, `ClientRequestHost`, `ClientRequestPath`, `ClientRequestUserAgent`, `ColoCode`, `ConnectionCloseReason`, `ConnectionCloseSource`, `ConnectionID`, `ConnectionTransportCloseCode`, `EdgeEndTimestamp`, `EdgeStartTimestamp`, and `RayID`. | |
| - **WebSocket Analytics**: A new dataset with fields including `BytesReceivedClient`, `BytesReceivedOrigin`, `BytesSentClient`, `BytesSentOrigin`, `ClientASN`, `ClientIP`, `ClientRequestHost`, `ClientRequestPath`, `ClientRequestUserAgent`, `ColoCode`, `ConnectionCloseReason`, `ConnectionCloseSource`, `ConnectionID`, `ConnectionTransportCloseCode`, `EdgeEndTimestamp`, `EdgeStartTimestamp`, and `RayID`. | |
| - **WebSocket Analytics**: A new dataset with fields including `BytesReceivedClient`, `BytesReceivedOrigin`, `BytesSentClient`, `BytesSentOrigin`, `ClientASN`, `ClientIP`, `ClientRequestHost`, `ClientRequestPath`, `ClientRequestUserAgent`, `ColoCode`, `ConnectionCloseReason`, `ConnectionCloseSource`, `ConnectionID`, `ConnectionTransportCloseCode`, `EdgeEndTimestamp`, `EdgeStartTimestamp`, and `RayID`. |
|
Review supplement — the rendered review body dropped the backtick-quoted text due to a shell escaping issue. Here is the intended summary: 1 issue needs fixing before merge. Duplicate changelog entry — The New datasets section lists WebSocket Analytics twice (lines 11–12). This appears to be a code generator bug in the source data or template. The PR description also contains the same duplicate. Labels — Already appropriately labeled ( Manual edit risk — No manual edits appear at risk of being overwritten. All new field descriptions in Field description quality — Descriptions are accurate and consistent with existing generated dataset pages. The new WebSocket Analytics fields and Email Security Alert fields look correct. |
|
I reviewed PR #31486 and posted my feedback directly on the pull request. SummaryThe PR is an automated sync that adds:
Issue FoundDuplicate changelog entry — The "New datasets" section of the changelog lists WebSocket Analytics twice (consecutive identical bullets). This appears to be a code generator bug. I posted an inline suggestion to remove the duplicate line and flagged that the PR description has the same duplication. LabelsThe PR is already appropriately labeled:
Manual Edit RiskNo manual edits appear at risk of being overwritten. All new field descriptions follow the standard generated format used across other Logpush dataset pages. |
|
Preview URL: https://aab4d93d.preview.developers.cloudflare.com Files with changes (up to 15) |
|
Closed in favor of #31674 |
2 participants
Summary
Automated sync of Logpush dataset field definitions from data/entities.
New datasets
BytesReceivedClient,BytesReceivedOrigin,BytesSentClient,BytesSentOrigin,ClientASN,ClientIP,ClientRequestHost,ClientRequestPath,ClientRequestUserAgent,ColoCode,ConnectionCloseReason,ConnectionCloseSource,ConnectionID,ConnectionTransportCloseCode,EdgeEndTimestamp,EdgeStartTimestamp, andRayID.BytesReceivedClient,BytesReceivedOrigin,BytesSentClient,BytesSentOrigin,ClientASN,ClientIP,ClientRequestHost,ClientRequestPath,ClientRequestUserAgent,ColoCode,ConnectionCloseReason,ConnectionCloseSource,ConnectionID,ConnectionTransportCloseCode,EdgeEndTimestamp,EdgeStartTimestamp, andRayID.Updated fields in existing datasets
BCC,DKIMResult,DMARCPolicy,DMARCResult, andSPFResult.Files changed
src/content/docs/logs/logpush/logpush-job/datasets/account/— dataset pagessrc/content/docs/logs/logpush/logpush-job/datasets/zone/— dataset pagessrc/content/changelog/logs/2026-06-16-log-fields-updated.mdx— changelogDocumentation checklist