-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Example custom semgrep rule for detecting fixed time references that is stored in repo for scanning against pull requests #26647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+105
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Preview URL: https://4c8ec30d.preview.developers.cloudflare.com |
…ep] in commit message
… when run during development we want to consider all changes made to the working directory
…and uncommitted changes in the local semgrep check
kodster28
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a github workflow change that impacts the semgrep workflow.
Until now the semgrep scan has been using semgrep ci which uses managed rules and is done when manually triggered and on a cron schedule. This PR intends to allow the execution of custom rules located in the
.semgrepdirectory when pull requests are made through the use of semgrep scanincludes:
.semgrep/dates-in-docs.yamlthat marks matches of the pattern[Cc]oming [Ss]oonand for digit numbers as a stand-in for year in dates as an error but does not return an error code to the workflow which should avoid impacting any users even if there are issues.tools/semgrep-repo-rulesthat executes the same rule matching by semgrep locally