Support building with old versions of upstream BoringSSL #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornelski
force-pushed
the
back-compat
branch
2 times, most recently
from
64d266b to
94acdc8
Compare
Merged
kornelski
force-pushed
the
back-compat
branch
from
94acdc8 to
6a37a70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of public APIs depending on
mlkem.hmade the whole library impossible to build with older include headers, even if the new Rust key encapsulation API isn't used. Similarly, mere existence of the newSslCredentialrequires symbols that may not be available in pre-compiled bssl libraries.When the build is given a
BORING_BSSL_PATH/BORING_BSSL_FIPS_PATH, it doesn't have choice over the upstream version.I've made the sys crate tolerate some header files missing, to gracefully support a wide range of BoringSSL versions. It will gracefully skip generating Rust bindings for the unavailable APIs. The features can still be made mandatory by setting their feature flags.