Conversation
|
I don't want to remove support for netstandard2.0 or netstandard2.1. It's entirely plausible that there are people using this who are targeting .NET Framework, and I'd really rather not break them. It would also break projects which are themselves are class libraries which target netstandard in order to allow their dependents to use .NET Framework. (See https://github.com/googleapis/google-cloudevents-dotnet for one such example...) The targeting of netstandard2.1 and netstandard2.0 is (IIRC) to avoid addition dependencies for other dependents that are targeting netstandard2.1. There may be other reasons that I can't remember too... |
be4fd7f to
2694b2d
Compare
Signed-off-by: Erwin <erwinkramer@hotmail.com>
2694b2d to
aff01e0
Compare
Signed-off-by: Erwin <erwinkramer@hotmail.com>
LangVersionLangVersion: 10
@jskeet Sure, a roadmap in the readme could help, stating how it will go from unsupported to supported frameworks gradually. Currently only .NET 8 and up are supported by MS, but the .NET Framework 4.x support is still there as well from Microsoft, but eventually that will get unsupported (officially) by Microsoft as well, then it might be a good time to drop support here as well? If you align official support from Microsoft with what we're doing here, we're should only be catering to consumers related to .NET Framework 4.x and .NET 8 or larger - which would mean we could drop For now, I redid the PR and just made the |
If MS ever does stop supporting .NET Framework, we should definitely revisit at that point. My gut feeling is that's many years away though. Until then, targeting netstandard 2.0 is the way to support both, so I'd rather keep it until then. (But just to clarify, if it ever gets to the point where only .NET is supported, I'd be happy to remove support for netstandard at the same time as .NET Framework)
Yup, absolutely - will review now. |
jskeet
left a comment
There was a problem hiding this comment.
Yup, this looks fine - thanks for reworking.
This PR makes sure to:
10throughout the repo.As a reference (or point for discussion), Microsoft's advice for
netstandardcan be found here.Closes #333.