Skip to content

Log file names should be consistent across CLI, and web#1247

Merged
gayanW merged 1 commit intov1from
AIENG-346-1
Feb 25, 2026
Merged

Log file names should be consistent across CLI, and web#1247
gayanW merged 1 commit intov1from
AIENG-346-1

Conversation

@gayanW
Copy link
Contributor

@gayanW gayanW commented Feb 24, 2026

Before:

| File           | Status                  |
|----------------|-------------------------|
| app.log        | ✓ Recorded successfully |
| nested-app.log | ✓ Recorded successfully |

After:

| File             | Status                  |
|------------------|-------------------------|
| app.log          | ✓ Recorded successfully |
| nested/app.log   | ✓ Recorded successfully |

The backend code is also modified, so that the web UI shows the same name as the CLI output.
https://github.com/launchableinc/mothership/pull/13261

@launchable-app

This comment has been minimized.

return False


def normalize_filename(filename: str) -> str:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, did you solve this problem as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I forgot the original reason that we decided to replace spaces with '-'.
But I remember that you said file names like foo-.log are not ideal, so that we might have to change it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was because 500 error was occurring when the whitespace was included. So, we first need to modify the intake side to accept the whitespace. Then, we need to delete this method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry let me add it back, until we figure out how to handle white spaces in backend.

@ono-max
Copy link
Contributor

ono-max commented Feb 24, 2026

@gayanW

CI is failing now.

@gayanW
Copy link
Contributor Author

gayanW commented Feb 24, 2026

@ono-max Fixed.

@gayanW gayanW merged commit 4b33666 into v1 Feb 25, 2026
13 checks passed
@gayanW gayanW deleted the AIENG-346-1 branch February 25, 2026 04:40
@github-actions github-actions bot mentioned this pull request Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants