Conversation
takanabe
force-pushed
the
tw-ignore-git-files
branch
from
ea587bc to
37c03e6
Compare
| @@ -0,0 +1,4 @@ | |||
| # Git files | |||
| .git | |||
There was a problem hiding this comment.
We're installing git in our Dockerfile. Do you think that it has a negative impact if we exclude gitfile?
Line 5 in 93a220d
There was a problem hiding this comment.
If my understanding is correct, this Git that you mentioned command is required when users record a commit or perform a build.
However, the .git directory (which contains the smart-tests history) is not necessary for building smart-tests, so it is excluded.
There was a problem hiding this comment.
Thanks for your explanation.
| @@ -0,0 +1,4 @@ | |||
| # Git files | |||
| .git | |||
There was a problem hiding this comment.
If my understanding is correct, this Git that you mentioned command is required when users record a commit or perform a build.
However, the .git directory (which contains the smart-tests history) is not necessary for building smart-tests, so it is excluded.
3 participants
We found git files are included in Docker images but I don't think we need them in the image. Could you confirm if they are not necessary?
Probably, it is better to include necessary files only rather than adding ignored files to dockerignore but I'm not familir with the code base now. So, let me do this approach for now.