Redo backporting the recent CLI changes by merging main #1117
Conversation
want to use from fail fast mode validator
…essage with red color
based on feedback
Introduce fail fast mode
ninjinkun
changed the base branch from
smart-tests
to
smart-tests-revert-backport-2
ninjinkun
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR represents a comprehensive backport of recent CLI changes from the main branch into the smart-tests branch, including major architectural improvements and new features. The changes include implementing fail-fast mode, adding PTS v2 support, and various bug fixes and enhancements.
Key changes include:
- Implementation of fail-fast mode with validation and error handling
- Addition of PTS v2 support through workspace state management
- New command structure with separated Command enum and enhanced tracking
- Comprehensive test coverage for new typer types and functionality
Reviewed Changes
Copilot reviewed 53 out of 54 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
tests/utils/test_typer_types.py |
New comprehensive test suite for typer type parsing with edge cases |
tests/utils/test_fail_fast_mode.py |
New tests for fail-fast mode validation functionality |
tests/test_runners/test_pytest.py |
Enhanced pytest parser tests with longrepr handling |
smart_tests/utils/typer_types.py |
Major refactor to class-based type system with backward compatibility |
smart_tests/utils/fail_fast_mode.py |
New fail-fast mode implementation with validation logic |
smart_tests/utils/launchable_client.py |
Added workspace state caching and PTS v2 support |
| Java source files | Major commit ingestion refactor with file collection support |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| command.extend(_build_proxy_option(os.getenv("HTTPS_PROXY"))) | ||
| command.extend([ | ||
| "-jar", | ||
| cygpath(jar_file_path), |
There was a problem hiding this comment.
The command line argument order has changed - the repository name argument is now added after all options, but the old command format 'ingest:commit' has been removed. This could break existing JAR file compatibility.
|
@Konboi Please review this. You don’t need to check it in detail, just take a quick look to see that the backport matches your intention and doesn't have wrong AI-generated code. |
Konboi
left a comment
Konboi
left a comment
There was a problem hiding this comment.
Checked. I can't find any issues
|
@Konboi Thank you! |
#1112 contained wrong code generated by Claude Code because I asked Claude cherry-pick the recent commits in
mainbranch then integrate them into the Smart Tests CLI code base. I reverted them #1120, and then mergedmainbranch intosmart-testsbranch, and then resolved conflicts manually.This PR includes following features: