Skip to content

test(talk): fetch rooms once before checking modifiedSince #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-nc merged 1 commit into from
Aug 11, 2026
Merged

test(talk): fetch rooms once before checking modifiedSince #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/actual_tests/talk_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ def test_conversation_create_delete(nc):
def test_get_conversations_modified_since(nc):
if nc.talk.available is False:
pytest.skip("Nextcloud Talk is not installed")
# Talk creates the "Note to self", sample and changelog conversations while serving a user's first
# rooms request, after it has captured the timestamp it reports in `X-Nextcloud-Talk-Modified-Before`.
# Those rooms are therefore newer than that timestamp; fetch once up front so that their creation
# cannot land inside the window checked below.
nc.talk.get_user_conversations()
conversation = nc.talk.create_conversation(talk.ConversationType.GROUP, "admin")
try:
conversations = nc.talk.get_user_conversations()
Expand All @@ -102,6 +107,8 @@ def test_get_conversations_modified_since(nc):
async def test_get_conversations_modified_since_async(anc):
if await anc.talk.available is False:
pytest.skip("Nextcloud Talk is not installed")
# see the comment in the sync test above
await anc.talk.get_user_conversations()
conversation = await anc.talk.create_conversation(talk.ConversationType.GROUP, "admin")
try:
conversations = await anc.talk.get_user_conversations()
Expand Down