[pre-commit.ci] pre-commit autoupdate - #458
Merged
Merged
Conversation
Contributor
|
The failing |
oleksandr-nc
added a commit
that referenced
this pull request
Aug 11, 2026
`test_get_conversations_modified_since` fails intermittently across the matrix (seen on #458 and earlier on `main`), always as `assert not [<Conversation name=Note to self>, <Conversation name=Let's get started!>]`. Talk captures `X-Nextcloud-Talk-Modified-Before` (T) at the *start* of `getRooms` and only then dispatches `BeforeRoomsFetchEvent` ([RoomController.php:240-243](https://github.com/nextcloud/spreed/blob/main/lib/Controller/RoomController.php#L240)), whose listeners create the note-to-self, sample and changelog conversations the first time a user fetches rooms. Those rooms get a `lastActivity` newer than the T already reported, and the server filter is `lastActivity >= modifiedSince`. The test asks for `T + 2`, so it only passes while that creation finishes inside 2 seconds. Measured on an idle local server it already takes ~1.15 s. Fetch the rooms once before the timed sequence so the lazy creation happens outside the checked window. Reproduced end to end by making sample creation exceed the margin (Talk's `samples_directory`), then running the real test as a fresh admin user: current test fails, patched test passes, same server and conditions. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved conversation modification-date filtering tests by excluding pre-existing default rooms from results. * Synchronous and asynchronous conversation list behavior is now validated more reliably. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Oleksandr Piskun <oleksandr2088@icloud.com>
updates: - [github.com/PyCQA/isort: 9.0.0b1 → 9.0.0b2](PyCQA/isort@9.0.0b1...9.0.0b2) - [github.com/tox-dev/pyproject-fmt: v2.26.0 → v2.27.0](tox-dev/pyproject-fmt@v2.26.0...v2.27.0) - [github.com/astral-sh/ruff-pre-commit: v0.16.1 → v0.16.2](astral-sh/ruff-pre-commit@v0.16.1...v0.16.2)
oleksandr-nc
force-pushed
the
pre-commit-ci-update-config
branch
from
August 11, 2026 09:39
6669f7b to
6c0ef73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates: