Refactor module loading API using Config-based entrypoint#30
Draft
jtakakura wants to merge 5 commits intoclojurewasm:mainfrom
Draft
Refactor module loading API using Config-based entrypoint#30jtakakura wants to merge 5 commits intoclojurewasm:mainfrom
jtakakura wants to merge 5 commits intoclojurewasm:mainfrom
Conversation
402fed8 to
cfc7d53
Compare
cfc7d53 to
1c672cc
Compare
1c672cc to
23251b4
Compare
23251b4 to
931dec5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the WasmModule loading API to consolidate various loading parameters into a single Config structure, as proposed in #29. This change simplifies the API surface and ensures that all resource limits are applied consistently before module execution.
Major Changes
Rationale
The previous loading API was becoming complex as more configuration options were added. By moving parameters into a Config struct, we provide a cleaner interface for embedders and a more robust foundation for future features, such as execution cancellation.
This refactoring is a prerequisite for the cancellation mechanism currently in draft at #28.
Related Issue
Closes #29