Repository navigation
Conversation
The position of a form inside the one whose indent spec applies was counted by moving back over its siblings, and moving back over a discarded form takes two steps, one for the form and one for its #_. So a #_ form before the bindings of letfn gave them position 2 instead of 1, and their functions got indented like calls. Now neither counts, as cljfmt and clojure-ts-mode skip discarded forms there too.
bbatsov
force-pushed
the
skip-discarded-inner-index
branch
from
November 3, 2026 13:45
8ccb0ce to
210e875
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
#_form beforeletfn's bindings shifted their position by two, since moving back over it takes one step for the form and one for the#_, so the functions got indented like calls. Discarded forms don't count there now, which is what cljfmt and clojure-ts-mode do.