Skip to content

Deduplicate pending scheduled row queue entries - #5951

Open
Shubham8287 wants to merge 1 commit into
masterfrom
shub/fix-schedule-update
Open

Shubham8287 wants to merge 1 commit into
masterfrom
shub/fix-schedule-update

Conversation

@Shubham8287

Copy link
Copy Markdown
Contributor

Description of Changes

Fixes a scheduler regression where interval scheduled reducers could enqueue duplicate pending calls for
the same scheduled row.

It can happen only if, updated row is exactly same as old scheduled row: Detailed report: https://discord.com/channels/1037340874172014652/1549683737200168981/1549683737200168981.

  • Track pending scheduled row entries with HashMap<ScheduledFunctionId, DelayQueue::Key>.
  • Replace an existing pending queue entry when the same scheduled row is scheduled again.

API and ABI breaking changes

NA

Rollback safety impact

NA

Expected complexity level and risk

1

Testing

Added new tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant