Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Scheduled function parameter preparation previously returned generic errors, so both scheduler paths logged datastore and BSATN failures, stale schedules, and invalid saved arguments at the same error level.
This change introduces typed errors so the scheduler can preserve that distinction:
error!warn!Both scheduled procedure and reducer paths use the classification. A unit test covers all six error categories.
Addresses #5767.
API and ABI breaking changes
None.
Rollback safety impact
n/a
Expected complexity level and risk
2 - The change is limited to scheduler error classification and logging. It does not change public APIs, database storage, or scheduling behavior.
Testing
cargo test --locked -p spacetimedb-core --libcargo fmt --check -p spacetimedb-coregit diff --check