Add args column to view backing tables#5300
Open
joshua-spacetime wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Review #5287 first.
This patch updates view backing table schemas to have a single private column
arg_hash. Previously sender-scoped views had asendercolumn for the calling identity, however now that's been replaced with a single unifiedarg_hashcolumn that encodes the calling identity within it.When we add parameterized views, the view args will also be encoded in this hash and stored in this column.
This column exists for both anonymous and sender scoped views meaning that the backing tables for all views now have the same number of private columns - one.
This hash is now used as a runtime variable that the query engine uses to evaluate view table scans.
In order to keep the diff small, this patch does update view read sets with this new hash value. That change has a larger blast radius and will be done in the next set of changes.
API and ABI breaking changes
N/A
Expected complexity level and risk
2
Testing
Existing coverage.