Move index scan tests into benchmark job#5298
Merged
Merged
Conversation
joshua-spacetime
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
joshua-spacetime
changed the title
joshua-spacetime
force-pushed
the
joshua/move-index-scan-tests
branch
from
132542e to
a6fc078
Compare
bfops
approved these changes
Jun 12, 2026
bfops
left a comment
bfops
left a comment
Collaborator
There was a problem hiding this comment.
my code-owned changes LGTM. I can't speak for the rest of the PR.
bfops
approved these changes
Jun 12, 2026
bfops
left a comment
bfops
left a comment
Collaborator
There was a problem hiding this comment.
alright rest of the diff seems fine to me too
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Moves
test_index_scansto its own job that uses the same runner as the keynote benchmark.This test had several issues:
ns(nanosecond) andus(microsecond) suffixesAs a result it would occasionally flake.
Now it runs on dedicated hardware in an isolated environment, so we shouldn't see anymore flakes.
API and ABI breaking changes
N/A
Expected complexity level and risk
1
Testing
N/A