Refactor smoketest publish and subscribe helpers to builder pattern#5283
Open
clockwork-labs-bot wants to merge 14 commits into
Open
Refactor smoketest publish and subscribe helpers to builder pattern#5283clockwork-labs-bot wants to merge 14 commits into
clockwork-labs-bot wants to merge 14 commits into
Conversation
bfops
reviewed
Jun 11, 2026
bfops
reviewed
Jun 11, 2026
bfops
previously approved these changes
Jun 11, 2026
bfops
left a comment
Collaborator
There was a problem hiding this comment.
LGTM if it's passing CI. still some inline questions though.
bfops
reviewed
Jun 11, 2026
bfops
reviewed
Jun 11, 2026
bfops
reviewed
Jun 11, 2026
bfops
reviewed
Jun 11, 2026
bfops
reviewed
Jun 11, 2026
bfops
reviewed
Jun 11, 2026
bfops
reviewed
Jun 11, 2026
Contributor
Author
|
Pushed
I left |
bfops
reviewed
Jun 11, 2026
bfops
reviewed
Jun 11, 2026
This reverts commit 350de43.
bfops
reviewed
Jun 12, 2026
…/master' into bot/smoketest-builder-options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Refactors the Rust smoketest helper surface so publish and subscribe variants use builders instead of parallel helper methods.
publish_module*helper variants withSmoketest::publish()and fluent options for name, clear, current database, break clients, stdin, replicas, organization, and source modules.subscribe_*/subscribe_background*variants withSmoketest::subscribe(...).expect_rows(...).confirmed(...).background().API and ABI breaking changes
Internal smoketest helper API change only. No product API or ABI changes.
Expected complexity level and risk
2
This touches many smoketest call sites, but the underlying CLI command behavior remains centralized in the same helper internals.
Testing