Compilation guard && tokio::sync re-export from runtime crate.#5255
Open
Shubham8287 wants to merge 2 commits into
Open
Compilation guard && tokio::sync re-export from runtime crate.#5255Shubham8287 wants to merge 2 commits into
tokio::sync re-export from runtime crate.#5255Shubham8287 wants to merge 2 commits into
Conversation
Shubham8287
changed the title
tokio::sync re-export from runtime crate.
kim
reviewed
Jun 10, 2026
| @@ -1,3 +1,11 @@ | |||
| #[cfg(all(feature = "tokio", feature = "simulation"))] | |||
Contributor
There was a problem hiding this comment.
Suggested change
| #[cfg(all(feature = "tokio", feature = "simulation"))] | |
| #[cfg(or(all(feature = "tokio", feature = "simulation"), not(any(feature = "tokio", feature = "simulation")))] |
Not that this is much clearer, feel free to ignore 😅
| // executor-agnostic, so driving them from the deterministic simulation runtime | ||
| // remains deterministic. | ||
| // | ||
| // Callers must avoid APIs that block or park OS threads on their own, such as |
Contributor
There was a problem hiding this comment.
Are there any other known besides blocking_send? We should at least be documenting those very loudly to avoid surprises down the line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Runtime specific changes from #5113.
spacetimedb-runtimeenforces exactly one feature at compile time:tokioorsimulation. It rejects both-enabled and neither-enabled builds explicitly.This also keeps
tokio::syncre-exported from runtime, look at code comment for reasoning.API and ABI breaking changes
NA
Expected complexity level and risk
1