[TS]: Primary keys for query builder views#4573
Open
joshua-spacetime wants to merge 10 commits intojoshua/rust/transfer-pk-to-viewfrom
Open
[TS]: Primary keys for query builder views#4573joshua-spacetime wants to merge 10 commits intojoshua/rust/transfer-pk-to-viewfrom
joshua-spacetime wants to merge 10 commits intojoshua/rust/transfer-pk-to-viewfrom
Conversation
joshua-spacetime
force-pushed
the
joshua/ts/transfer-pk-to-view
branch
from
85c6475 to
1494900
Compare
joshua-spacetime
force-pushed
the
joshua/rust/transfer-pk-to-view
branch
from
2088fbc to
ff7bec7
Compare
joshua-spacetime
force-pushed
the
joshua/ts/transfer-pk-to-view
branch
from
1494900 to
c777e7b
Compare
joshua-spacetime
force-pushed
the
joshua/rust/transfer-pk-to-view
branch
from
ff7bec7 to
1be82af
Compare
joshua-spacetime
force-pushed
the
joshua/ts/transfer-pk-to-view
branch
from
c777e7b to
e9e6dd2
Compare
joshua-spacetime
force-pushed
the
joshua/rust/transfer-pk-to-view
branch
from
1be82af to
c8d8630
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Equivalent changes to #4572, but for typescript, and minus any server side changes.
Query builder views can now be annotated with the
.query()return type, in addition to the pre-existing.array()return type. If.query()is used, the view will have a primary key if the underlying table that it returns has one. This means client-sideonUpdatecallbacks will be generated.API and ABI breaking changes
None.
t.array()return type views are still supported.Expected complexity level and risk
3
Testing
The equivalent typescript versions of the sdk tests added in #4572.