Repository navigation
Release 0.3.0: require ActiveRecord 8.1 - #39
Merged
Merged
Conversation
The only Clio consumer of this gem (themis) runs ActiveRecord 8.1, but CI only exercised 7.0 and 7.1, so we had no signal that the gem works on the version we actually ship. Running the suite on 8.1 immediately surfaced a break in the spec setup: MigrationContext no longer accepts the SchemaMigration class as its second argument (removed in 7.2), so the suite could not boot. Letting it pick the schema migration from the connection works on 7.1+. Dropping the 7.0 appraisal also removes the sqlite3 1.x and concurrent-ruby pins that only existed to keep that old adapter loading.
CI now only verifies ActiveRecord 8.1, so publishing a version that still claims 7.0+ support would promise compatibility we no longer test. Declaring activerecord as a runtime dependency lets RubyGems stop apps on older Rails from resolving to this version, instead of relying on users reading the README. This is a minor bump because dropping supported Rails versions is a breaking change for a pre-1.0 gem. 0.2.3 was never published, so 7.x users stay on 0.2.2, which has the same library code.
anthonyoconnorclio
marked this pull request as ready for review
November 2, 2026 22:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Overlord shows the only Clio consumer of this gem is
clio/themis, which runs ActiveRecord 8.1.4. CI only tested AR 7.0 and 7.1, so we had no signal the gem works on the version we actually ship.Running the suite on 8.1 confirmed the gap: the spec setup couldn't boot at all.
ActiveRecord::MigrationContext.newstopped accepting theSchemaMigrationclass as its second argument in Rails 7.2. Passing only the migrations path lets it pick the schema migration from the connection. The gem code itself needed no changes; all 20 specs pass on 8.1.Since CI now only verifies 8.1, this also releases 0.3.0 marked as 8.1-only, so we don't publish a version that claims support we no longer test:
activerecord >= 8.1is now a runtime dependency (it was only a development dependency before), so RubyGems will stop apps on older Rails from resolving to 0.3.0 rather than relying on users reading the README.0.2.3was never published to RubyGems. Library code is unchanged sincev0.2.2, so the README now points ActiveRecord 6.1–8.0 users atv0.2.2.Dropping the 7.0 appraisal also removes the
sqlite3 ~> 1.4andconcurrent-ruby 1.3.4pins that only existed to keep the old AR 7.0 SQLite adapter loading.Releasing
Publishing is triggered by the
gem-pushworkflow when a GitHub release is published. After merge, create a release with tagv0.3.0onmaster.For reviewers
gemfiles/is gitignored, so the generated appraisal gemfiles aren't part of this diff; CI runsappraisal installto generate them.