Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions webapp/local_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,9 @@ type CodeResponse struct {
Code string
State string
}

// bindLocalServer initializes a LocalServer that will listen on a randomly available TCP port.
func bindLocalServer() (*localServer, error) {
listener, err := net.Listen("tcp4", "127.0.0.1:0")
func bindLocalServerWithPort(port int) (*localServer, error) {
addr := fmt.Sprintf("127.0.0.1:%d", port)
listener, err := net.Listen("tcp4", addr)
if err != nil {
return nil, err
}
Expand All @@ -27,6 +26,12 @@ func bindLocalServer() (*localServer, error) {
}, nil
}

// bindLocalServer initializes a LocalServer that will listen on a randomly available TCP port.
func bindLocalServer() (*localServer, error) {
return bindLocalServerWithPort(0)

}

type localServer struct {
CallbackPath string
WriteSuccessHTML func(w io.Writer)
Expand Down
18 changes: 16 additions & 2 deletions webapp/webapp_flow.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ import (
"io"
"net/http"
"net/url"
"os"
"strings"

"strconv"
"github.com/cli/oauth/api"
)

Expand All @@ -29,7 +30,20 @@ type Flow struct {

// InitFlow creates a new Flow instance by detecting a locally available port number.
func InitFlow() (*Flow, error) {
server, err := bindLocalServer()

portStr := os.Getenv("GH_OAUTH_PORT")
port := 0


if portStr != "" {
var err error
port, err = strconv.Atoi(portStr)
if err != nil {
port = 0
}
}

server, err := bindLocalServerWithPort(port)
if err != nil {
return nil, err
}
Expand Down