Skip to content

chore(ui,localizations,shared): Use distinct password placeholder for sign-up forms#8082

Open
wobsoriano wants to merge 2 commits intomainfrom
rob/USER-4479
Open

chore(ui,localizations,shared): Use distinct password placeholder for sign-up forms#8082
wobsoriano wants to merge 2 commits intomainfrom
rob/USER-4479

Conversation

@wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Mar 14, 2026

Summary

A customer reports that "Enter your password" on the sign-up continue form ("Fill in missing fields") is confusing. Users interpret it as entering an existing password rather than creating a new one.

This PR:

  • Adds a new formFieldInputPlaceholder__signUpPassword localization key with "Create a password" wording
  • Updates SignUpStart and SignUpContinue to use the new key instead of the shared formFieldInputPlaceholder__password ("Enter your password")
  • Sign-in forms remain unchanged with "Enter your password"
  • Adds placeholder assertions in SignUpStart, SignUpContinue, and SignInFactorOne tests

See https://clerkinc.slack.com/archives/C07JK3YT2G2/p1773068945680939

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes
    • Updated the password field placeholder in sign-up forms to display "Create a password" instead of a generic placeholder, providing clearer guidance during account creation.

Sign-up forms previously shared the same "Enter your password" placeholder
as sign-in, which confused users into thinking they needed an existing
password. Added a new `formFieldInputPlaceholder__signUpPassword` localization
key with "Create a password" wording for SignUpStart and SignUpContinue.
@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2026

🦋 Changeset detected

Latest commit: 9d35079

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@clerk/localizations Patch
@clerk/shared Patch
@clerk/ui Patch
@clerk/react Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/chrome-extension Patch
@clerk/clerk-js Patch
@clerk/expo-passkeys Patch
@clerk/expo Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/hono Patch
@clerk/msw Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Mar 14, 2026 4:39pm

Request Review

@wobsoriano wobsoriano changed the title fix(ui): use distinct password placeholder for sign-up forms chore(ui,localizations,shared): Use distinct password placeholder for sign-up forms Mar 14, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 14, 2026

📝 Walkthrough

Walkthrough

This pull request introduces a distinct password placeholder for sign-up forms across the Clerk packages. A new localization key formFieldInputPlaceholder__signUpPassword with the value "Create a password" is added to the English localization resource. The localization resource type definition is extended to include this new field. The SignUpStart and SignUpContinue components are updated to use this new key instead of the generic password placeholder. Test files are updated with new assertions to verify the presence of the "Create a password" placeholder text in sign-up scenarios.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The PR title accurately describes the main change: introducing a distinct password placeholder for sign-up forms across the ui, localizations, and shared packages.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 14, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8082

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8082

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8082

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8082

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8082

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8082

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8082

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8082

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8082

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8082

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8082

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8082

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8082

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8082

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8082

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8082

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8082

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8082

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8082

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8082

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8082

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8082

commit: 9d35079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant