fix(ci): add dependsOn to integration test turbo tasks#8073
fix(ci): add dependsOn to integration test turbo tasks#8073jacekradko wants to merge 1 commit intomainfrom
Conversation
Integration tests were only triggered by changes to integration/** files. Changes to @clerk/* packages never invalidated the turbo cache, so tests were silently skipped (affected=0) on PRs that only changed package code. Add dependsOn with the primary package build task for each integration test. Since each package build already depends on its transitive deps via ^build, this correctly captures source changes, dependency updates, and any other package-level changes.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change adds 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Comment |
Summary
dependsOnwith the primary@clerk/*package build task to each integration test turbo taskbuildtask already uses^buildfor transitive deps, so this correctly captures source changes, dependency updates, and any package-level changesinputs: ["integration/**"]is kept for detecting test infrastructure changes (not part of any package)Before: Integration tests only ran when
integration/files changed. All "passing" CI runs on PRs that changed@clerk/*packages were actually skipped (affected=0, ~24s job duration) — the tests never executed.After: Turbo's package-level change detection triggers integration tests when the relevant
@clerk/*package (or any of its transitive dependencies) changes.Mapping
@clerk/nextjs#build@clerk/nextjs#build,@clerk/react#build@clerk/express#build@clerk/hono#build@clerk/astro#build@clerk/expo#build@clerk/tanstack-react-start#build@clerk/vue#build@clerk/nuxt#build@clerk/react-router#build@clerk/nextjs#build,@clerk/vue#build@clerk/express#build,@clerk/backend#build@clerk/react#buildTest plan
affected=1on PRs that change@clerk/*package sourceSummary by CodeRabbit