Skip to content

fix(ci): add dependsOn to integration test turbo tasks#8073

Closed
jacekradko wants to merge 1 commit intomainfrom
jacek/fix-integration-turbo-inputs
Closed

fix(ci): add dependsOn to integration test turbo tasks#8073
jacekradko wants to merge 1 commit intomainfrom
jacek/fix-integration-turbo-inputs

Conversation

@jacekradko
Copy link
Member

@jacekradko jacekradko commented Mar 13, 2026

Summary

  • Add dependsOn with the primary @clerk/* package build task to each integration test turbo task
  • Each package's build task already uses ^build for transitive deps, so this correctly captures source changes, dependency updates, and any package-level changes
  • inputs: ["integration/**"] is kept for detecting test infrastructure changes (not part of any package)

Before: Integration tests only ran when integration/ files changed. All "passing" CI runs on PRs that changed @clerk/* packages were actually skipped (affected=0, ~24s job duration) — the tests never executed.

After: Turbo's package-level change detection triggers integration tests when the relevant @clerk/* package (or any of its transitive dependencies) changes.

Mapping

Test dependsOn
ap-flows, nextjs, nextjs:canary, quickstart, localhost, sessions, sessions:staging, handshake, handshake:staging @clerk/nextjs#build
generic @clerk/nextjs#build, @clerk/react#build
express @clerk/express#build
hono @clerk/hono#build
astro @clerk/astro#build
expo-web @clerk/expo#build
tanstack-react-start @clerk/tanstack-react-start#build
vue @clerk/vue#build
nuxt @clerk/nuxt#build
react-router @clerk/react-router#build
billing @clerk/nextjs#build, @clerk/vue#build
machine @clerk/express#build, @clerk/backend#build
custom @clerk/react#build

Test plan

  • CI integration tests are marked affected=1 on PRs that change @clerk/* package source
  • CI integration tests are still skipped on PRs that only change unrelated files

Summary by CodeRabbit

  • Chores
    • Enhanced build system configuration to ensure proper ordering and dependency resolution during integration testing across multiple framework packages.

Integration tests were only triggered by changes to integration/** files.
Changes to @clerk/* packages never invalidated the turbo cache, so tests
were silently skipped (affected=0) on PRs that only changed package code.

Add dependsOn with the primary package build task for each integration
test. Since each package build already depends on its transitive deps
via ^build, this correctly captures source changes, dependency updates,
and any other package-level changes.
@vercel
Copy link

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Mar 13, 2026 5:13pm

Request Review

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 13, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8073

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8073

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8073

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8073

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8073

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8073

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8073

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8073

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8073

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8073

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8073

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8073

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8073

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8073

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8073

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8073

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8073

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8073

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8073

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8073

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8073

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8073

commit: d30190a

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: b42142b5-1be1-4857-8bd7-09f830dcc5b0

📥 Commits

Reviewing files that changed from the base of the PR and between b764267 and d30190a.

📒 Files selected for processing (1)
  • turbo.json

📝 Walkthrough

Walkthrough

The change adds dependsOn fields to multiple integration test configurations in turbo.json. These fields specify required build tasks that must complete before each corresponding test executes. Single-target dependencies are added to test entries like ap-flows, express, hono, and nextjs, while multi-target dependencies are added to generic, billing, machine, and custom test entries. This establishes explicit build prerequisites for all listed integration tests, requiring appropriate packages to build prior to test execution.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding dependsOn fields to integration test turbo tasks in the CI configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant