Skip to content

test(e2e): Expand tests for Tanstack React Start#8072

Open
tmilewski wants to merge 1 commit intomainfrom
tom/user-4963-expand-integration-tests-for-tanstack-react-start
Open

test(e2e): Expand tests for Tanstack React Start#8072
tmilewski wants to merge 1 commit intomainfrom
tom/user-4963-expand-integration-tests-for-tanstack-react-start

Conversation

@tmilewski
Copy link
Member

@tmilewski tmilewski commented Mar 13, 2026

Description

  • Add E2E tests for organizations, error handling, and proxy functionality for
    @clerk/tanstack-react-start
  • Add /me template route that exposes the full auth object via data-testid attributes for test assertions
  • Add OrganizationSwitcher to the template index route
  • Register withCustomRoles and withEmailCodesProxy app configs for TanStack Start

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: Test

Summary by CodeRabbit

  • New Features
    • Added Organization Switcher component to the home page, allowing users to easily switch between their organizations.
    • Introduced a new /me page that displays comprehensive user and organization information, including user ID, session ID, organization ID, assigned role, and organization slug.

@tmilewski tmilewski self-assigned this Mar 13, 2026
@vercel
Copy link

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Mar 13, 2026 5:13pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2026

🦋 Changeset detected

Latest commit: 1c4af4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 13, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8072

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8072

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8072

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8072

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8072

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8072

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8072

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8072

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8072

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8072

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8072

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8072

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8072

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8072

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8072

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8072

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8072

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8072

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8072

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8072

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8072

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8072

commit: 1c4af4e

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7fe1d7bc-8e58-4853-929f-103a89057635

📥 Commits

Reviewing files that changed from the base of the PR and between b764267 and 1c4af4e.

📒 Files selected for processing (8)
  • .changeset/tame-snakes-move.md
  • integration/presets/longRunningApps.ts
  • integration/templates/tanstack-react-start/src/routes/index.tsx
  • integration/templates/tanstack-react-start/src/routes/me.tsx
  • integration/tests/tanstack-start/error-handling.test.ts
  • integration/tests/tanstack-start/organizations.test.ts
  • integration/tests/tanstack-start/proxy.test.ts
  • package.json

📝 Walkthrough

Walkthrough

This pull request extends the TanStack React Start integration with organization support features and expanded test coverage. A new route at /me displays user and organization details via Clerk authentication. Two new long-running app configurations were added for testing with custom roles and email codes proxy environments. Integration tests were introduced to validate error handling, organization authentication with custom roles, and proxy behavior. The index route was updated to include an OrganizationSwitcher component. A changeset file was created, and the integration test script pattern was broadened to include all matching TanStack React Start variants.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main purpose of the PR: expanding end-to-end tests for the TanStack React Start package by adding test coverage for organizations, error handling, and proxy functionality.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant