Skip to content

test(e2e): Expand Vue testing#8068

Merged
brkalow merged 3 commits intomainfrom
tom/user-4961-expand-integration-tests-for-vue
Mar 13, 2026
Merged

test(e2e): Expand Vue testing#8068
brkalow merged 3 commits intomainfrom
tom/user-4961-expand-integration-tests-for-vue

Conversation

@tmilewski
Copy link
Member

@tmilewski tmilewski commented Mar 13, 2026

Description

  • Add 13 integration tests for @clerk/vue covering composables (useAuth, useUser, useSession, useOrganization), organization components (OrganizationList, CreateOrganization, OrganizationSwitcher), the <Show> component (signed-in/out, permission-based, fallback slots), and <SignOutButton>.
  • Add 8 Vue view templates and routes to the vue-vite integration app to support the new tests

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: Test

Summary by CodeRabbit

  • New Features

    • Added routes and pages showing auth state, user info, session details, sign-out flow, and organization pages (list, create, switch, show).
  • Tests

    • Added comprehensive integration tests covering composables, organization flows, sign-out, and conditional UI based on auth/permissions.
  • Chores

    • Added a placeholder changeset file (no functional changes).

@tmilewski tmilewski self-assigned this Mar 13, 2026
@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2026

🦋 Changeset detected

Latest commit: a974b30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Mar 13, 2026 8:34pm

Request Review

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 13, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8068

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8068

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8068

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8068

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8068

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8068

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8068

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8068

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8068

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8068

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8068

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8068

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8068

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8068

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8068

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8068

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8068

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8068

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8068

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8068

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8068

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8068

commit: a974b30

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7a9e0d9d-9a79-4071-a681-ab8c908ac450

📥 Commits

Reviewing files that changed from the base of the PR and between 56cf095 and a974b30.

📒 Files selected for processing (3)
  • integration/tests/vue/components.test.ts
  • integration/tests/vue/organizations.test.ts
  • integration/tests/vue/show-component.test.ts

📝 Walkthrough

Walkthrough

Adds a new changeset and extends the Vue + Vite integration with multiple Vue single-file components (AuthState, UserState, SessionState, OrgState, ShowComponent, SignOutPage, OrganizationListPage, CreateOrganizationPage) and registers corresponding routes in the router. Introduces Playwright integration tests (composables.test.ts, organizations.test.ts, show-component.test.ts, components.test.ts) to validate composables, organization UI, Show behavior, and sign-out; components.test.ts also updates test cleanup to use null-safe optional chaining.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'test(e2e): Expand Vue testing' directly and accurately reflects the main purpose of the PR: expanding end-to-end testing coverage for the Vue integration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@wobsoriano wobsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see it, thanks!

@brkalow brkalow merged commit 8bdc8c3 into main Mar 13, 2026
43 checks passed
@brkalow brkalow deleted the tom/user-4961-expand-integration-tests-for-vue branch March 13, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants