[WIP] Fix crash in navigation for Clerk's Client Trust feature#7853
Closed
Copilot wants to merge 1 commit intorelease/core-2from
Closed
[WIP] Fix crash in navigation for Clerk's Client Trust feature#7853Copilot wants to merge 1 commit intorelease/core-2from
Copilot wants to merge 1 commit intorelease/core-2from
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick changes from PR #7654: Fix React Native navigation crash
This PR addresses a crash that occurs in React Native when signing in with a password on a new/unrecognized device.
Issue
windowexists butwindow.locationis undefinednew URL(to, window.location.href), it crashes with "Cannot read property 'href' of undefined"Solution
window.location.hrefwindow.locationis undefined, use the custom router (routerPush/routerReplace) if providedChecklist
navigate()function inpackages/clerk-js/src/core/clerk.tsnavigate()functionOriginal prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.