-
Notifications
You must be signed in to change notification settings - Fork 406
fix(clerk-js): Reassign fetcherRef when fetcher changes #7145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: aeeafae The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughAdds a patch changeset and a useEffect to Changes
Sequence Diagram(s)sequenceDiagram
participant Component
participant useFetchHook as useFetch
participant fetcherRef as fetcherRef
Component->>useFetchHook: render with fetcher (fn A)
useFetchHook->>fetcherRef: set current = fn A
Note over useFetchHook,fetcherRef: on prop change
Component->>useFetchHook: render with new fetcher (fn B)
useFetchHook->>fetcherRef: useEffect updates current = fn B
Component->>useFetchHook: call fetch
useFetchHook->>fetcherRef: call current() -> fn B
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
This comment has been minimized.
This comment has been minimized.
913e749 to
aeeafae
Compare
Description
useFetchreceives afetcherfunction as a parameter, which is assigned to a ref internally. The problem is that when we switch resources, thefetcherfunction still points to old references. This PR ensures that thefetcherRefalways points to the latestfetcherparam.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit